[PATCH 2/2] DT: net: davinci_emac: "ti, davinci-no-bd-ram" property is actually optional

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[PATCH 2/2] DT: net: davinci_emac: "ti, davinci-no-bd-ram" property is actually optional

Sergei Shtylyov-3
The "ti,davinci-no-bd-ram" property for the DaVinci EMAC binding simply can't be
required one, as it's boolean (which means it's absent if false).

While at it, document the property better...

Signed-off-by: Sergei Shtylyov <[hidden email]>

---
 Documentation/devicetree/bindings/net/davinci_emac.txt |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: net/Documentation/devicetree/bindings/net/davinci_emac.txt
===================================================================
--- net.orig/Documentation/devicetree/bindings/net/davinci_emac.txt
+++ net/Documentation/devicetree/bindings/net/davinci_emac.txt
@@ -10,7 +10,6 @@ Required properties:
 - ti,davinci-ctrl-mod-reg-offset: offset to control module register
 - ti,davinci-ctrl-ram-offset: offset to control module ram
 - ti,davinci-ctrl-ram-size: size of control module ram
-- ti,davinci-no-bd-ram: has the emac controller BD RAM
 - interrupts: interrupt mapping for the davinci emac interrupts sources:
               4 sources: <Receive Threshold Interrupt
   Receive Interrupt
@@ -22,6 +21,7 @@ Optional properties:
               If absent, davinci_emac driver defaults to 100/FULL.
 - local-mac-address : 6 bytes, mac address
 - ti,davinci-rmii-en: 1 byte, 1 means use RMII
+- ti,davinci-no-bd-ram: boolean, does EMAC has BD RAM?
 
 Example (enbw_cmc board):
  eth0: emac@1e20000 {
_______________________________________________
Davinci-linux-open-source mailing list
[hidden email]
http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [PATCH 2/2] DT: net: davinci_emac: "ti, davinci-no-bd-ram" property is actually optional

Sergei Shtylyov-3
Hello.

On 01/28/2014 02:49 AM, Sergei Shtylyov wrote:

> The "ti,davinci-no-bd-ram" property for the DaVinci EMAC binding simply can't be
> required one, as it's boolean (which means it's absent if false).

> While at it, document the property better...

> Signed-off-by: Sergei Shtylyov <[hidden email]>

> ---
>   Documentation/devicetree/bindings/net/davinci_emac.txt |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

> Index: net/Documentation/devicetree/bindings/net/davinci_emac.txt
> ===================================================================
> --- net.orig/Documentation/devicetree/bindings/net/davinci_emac.txt
> +++ net/Documentation/devicetree/bindings/net/davinci_emac.txt
> @@ -10,7 +10,6 @@ Required properties:
>   - ti,davinci-ctrl-mod-reg-offset: offset to control module register
>   - ti,davinci-ctrl-ram-offset: offset to control module ram
>   - ti,davinci-ctrl-ram-size: size of control module ram
> -- ti,davinci-no-bd-ram: has the emac controller BD RAM
>   - interrupts: interrupt mapping for the davinci emac interrupts sources:
>                 4 sources: <Receive Threshold Interrupt
>    Receive Interrupt
> @@ -22,6 +21,7 @@ Optional properties:
>                 If absent, davinci_emac driver defaults to 100/FULL.
>   - local-mac-address : 6 bytes, mac address
>   - ti,davinci-rmii-en: 1 byte, 1 means use RMII
> +- ti,davinci-no-bd-ram: boolean, does EMAC has BD RAM?

    Too hasty, s/has/have/. Do I need to resend or this could be fixed when
applying?

WBR, Sergei

_______________________________________________
Davinci-linux-open-source mailing list
[hidden email]
http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
Loading...