[PATCH v2 0/2] net: davinci_emac: Fix interrupt requests and error handling

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH v2 0/2] net: davinci_emac: Fix interrupt requests and error handling

Christian Riesch
Hi,

since commit 6892b41d9701283085b655c6086fb57a5d63fa47 (Linux 3.11) the
davinci_emac driver is broken. After doing ifconfig down, ifconfig up,
requesting the interrupts for the driver fails. The interface remains dead
until the board is rebooted.

The first patch in this patchset reverts commit
6892b41d9701283085b655c6086fb57a5d63fa47 partially and makes the driver
useable again.

During the work on the first patch, a number of bugs in the error handling
of the driver's ndo_open code were found. The second patch fixes these bugs.

I believe the first patch meets the rules for stable kernels, I therefore added
the stable tag to this patch. The second patch is just cleanup, the code
that is fixed by this patch is only executed in case of an error.

Best regards,
Christian

Changes for v2:
- Added a longer commit message to the second patch, explaining the problems
  more detailed.

Christian Riesch (2):
  net: davinci_emac: Replace devm_request_irq with request_irq
  net: davinci_emac: Fix rollback of emac_dev_open()

 drivers/net/ethernet/ti/davinci_cpdma.c |    4 +--
 drivers/net/ethernet/ti/davinci_emac.c  |   53 ++++++++++++++++++++++++-------
 2 files changed, 44 insertions(+), 13 deletions(-)

--
1.7.9.5

_______________________________________________
Davinci-linux-open-source mailing list
[hidden email]
http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH v2 0/2] net: davinci_emac: Fix interrupt requests and error handling

David Miller-13
From: Christian Riesch <[hidden email]>
Date: Mon, 24 Mar 2014 13:46:25 +0100

> since commit 6892b41d9701283085b655c6086fb57a5d63fa47 (Linux 3.11) the
> davinci_emac driver is broken. After doing ifconfig down, ifconfig up,
> requesting the interrupts for the driver fails. The interface remains dead
> until the board is rebooted.
>
> The first patch in this patchset reverts commit
> 6892b41d9701283085b655c6086fb57a5d63fa47 partially and makes the driver
> useable again.
>
> During the work on the first patch, a number of bugs in the error handling
> of the driver's ndo_open code were found. The second patch fixes these bugs.
>
> I believe the first patch meets the rules for stable kernels, I therefore added
> the stable tag to this patch. The second patch is just cleanup, the code
> that is fixed by this patch is only executed in case of an error.

Series applied and patch #1 queued up for -stable, thanks!
_______________________________________________
Davinci-linux-open-source mailing list
[hidden email]
http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source